Simplify post-0021 bootstrap shell and signer denomination seams - #196
Merged
Conversation
Drop the test-only combine_plan door in favor of coin_ops::shape coverage, park BootstrapCombineContext on the planner, and exercise denomination e2e through one phase runner with shared Coinset fixtures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
combine_plandoor; keepBootstrapCombineContexton the planner and cover combine regressions incoin_ops::shape.run_signer_denomination_phase_with_test_overrides.test_support/bootstrap_shapeand share the ECO.181 ladder viaeco181_shape_ladder().Test plan
cargo test --manifest-path greenfloor-engine/Cargo.toml --lib -- signer_denomination shape::combine::testsPATH="$(pwd)/.venv/bin:$PATH" pre-commit run --all-files