Skip to content

Fix coin-ops blocked by shared Direct maker p2 watches - #197

Merged
hoffmang9 merged 2 commits into
mainfrom
fix/coin-ops-inventory-p2-exclusion
Aug 11, 2026
Merged

hoffmang9 merged 2 commits into
mainfrom
fix/coin-ops-inventory-p2-exclusion

Conversation

@hoffmang9

Copy link
Copy Markdown
Owner

Summary

  • Direct maker_puzzle_hash is the vault inventory CAT outer / receive inner; seeding it as a per-offer kind='p2' watch locked every coin of that asset and blocked combine/split (no_spendable_combine_coin_available).
  • Coin-ops now excludes spendable coins by durable coin-id watches only; per-offer p2 watches are seeded only when cancel metadata is is_presplit_like (explicit Presplit, or legacy NULL mode + fixed_delegated_puzzle_hash).
  • Heal/Dexie/post share that gate with cancel policy; ADR 0019 updated to match.

Test plan

  • cargo test --lib execute_managed_coin_op (coin-id exclusion / p2 ignored)
  • cargo test --lib classify_heals (Direct coin-only; NULL-mode presplit seeds CONDITIONS p2)
  • cargo test --lib is_presplit_like
  • cargo test --lib offer_post_persist_record (Direct watched_p2s empty)
  • On john-deere (or similar): with open Direct BYC sells, confirm combine plans execute instead of no_spendable_combine_coin_available

Direct maker_puzzle_hash is the vault inventory CAT outer / receive inner, so seeding it as a per-offer p2 watch locked every coin of that asset. Seed p2 watches only for presplit, and exclude spendable coins by coin-id only.
Share one is_presplit_like gate (including legacy NULL mode + fixed_delegated) so heal/Dexie/post seed CONDITIONS p2 watches consistently with cancel policy.
@hoffmang9
hoffmang9 merged commit 56d1efc into main Aug 11, 2026
3 checks passed
@hoffmang9
hoffmang9 deleted the fix/coin-ops-inventory-p2-exclusion branch August 11, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant