Fix coin-ops blocked by shared Direct maker p2 watches - #197
Merged
Merged
Conversation
Direct maker_puzzle_hash is the vault inventory CAT outer / receive inner, so seeding it as a per-offer p2 watch locked every coin of that asset. Seed p2 watches only for presplit, and exclude spendable coins by coin-id only.
Share one is_presplit_like gate (including legacy NULL mode + fixed_delegated) so heal/Dexie/post seed CONDITIONS p2 watches consistently with cancel policy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maker_puzzle_hashis the vault inventory CAT outer / receive inner; seeding it as a per-offerkind='p2'watch locked every coin of that asset and blocked combine/split (no_spendable_combine_coin_available).is_presplit_like(explicit Presplit, or legacy NULL mode +fixed_delegated_puzzle_hash).Test plan
cargo test --lib execute_managed_coin_op(coin-id exclusion / p2 ignored)cargo test --lib classify_heals(Direct coin-only; NULL-mode presplit seeds CONDITIONS p2)cargo test --lib is_presplit_likecargo test --lib offer_post_persist_record(Directwatched_p2sempty)no_spendable_combine_coin_available