Fix coin-ops free-inventory double-count and buffer-raid splits - #198
Merged
Conversation
Exclude watched makers from inventory buckets, credit live sells only toward target, and let excess exact clips fund smaller-rung low-watermark splits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
newly_executedfrom the pre-strategy snapshot), so open Direct makers no longer look like full target+buffer coverage.SplitSourceProtection::for_low_watermark_split(target-only, full-vault including watched makers) so excess/buffer exact clips can fund smaller-rung deficits; ADR 0024 records the policy.Test plan
cargo test -p greenfloor-engine --lib effective_countscargo test -p greenfloor-engine --lib shape_protectioncargo test -p greenfloor-engine --lib inventory_freshnesscargo test -p greenfloor-engine --lib eco181_shape_tableinsufficient cat coins/ excess-combine skips