Retry dusty CAT combines onto a remainder coin - #200
Merged
Conversation
…e dust floor. Spread-adjusted buy clips left sub-CAT change on the tightest covering set, so the shaper returned CannotFund even when another coin could absorb legal change.
…licit. The legal-change selector always sets an input cap, so dust never reached the greedy path; DustChangeFilter now enters combine from policy instead of a selection re-export.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CannotFundeven when a remainder coin could absorb legal change.combine_input_capleaves legal change. Daemon flat combine (no dust context) is unchanged.Test plan
shape::combinetests: third-coin remainder, two 25.025s alone still rejected, alternate pair with legal change preferredselectiontest: skip dusty two-coin cover and take remainder (ignore dust fragments)