Skip to content

chore(format): restore repository-wide Prettier baseline - #960

Open
moncher-dev wants to merge 1 commit into
mainfrom
symphony/hojinzs-github-symphony-944
Open

chore(format): restore repository-wide Prettier baseline#960
moncher-dev wants to merge 1 commit into
mainfrom
symphony/hojinzs-github-symphony-944

Conversation

@moncher-dev

@moncher-dev moncher-dev commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Issues

Summary

  • Adds a repository-level .prettierignore so generated/runtime output, the pnpm lockfile, and the hand-maintained Prettier config are outside prettier --check ..
  • Restores the Prettier baseline across the remaining tracked files. The reported pre-ignore failure count was 66; adding the ignore file first reduced the actual sweep scope to 59 files.

Change-point diagram

  • pnpm format.prettierignore excludes generated/config artifacts → Prettier validates the maintained repository sources and documentation → the 59-file baseline is clean

Start here

  • .prettierignore:1 — defines the durable repository-wide scan boundary
  • package.json:22 — existing pnpm format entry point that now passes against that boundary

User-Visible Behavior / Operational Impact

  • Contributors can run pnpm format on a clean checkout without unrelated baseline failures.
  • No CLI or runtime behavior changes.

Validation

  • Pre-ignore issue baseline: pnpm format — fail, 66 files
  • Post-ignore/pre-sweep: pnpm format — fail, 59 files
  • Post-sweep: pnpm format — pass
  • git diff --check — pass
  • pnpm lint — pass across 14 workspace projects
  • pnpm test — pass across 14 workspace projects
  • pnpm typecheck — pass across 14 workspace projects
  • pnpm build — pass across 14 workspace projects
  • Docker E2E: not applicable; formatting and ignore scope do not change integration behavior

Changeset

  • Not needed because this is formatting-only repository maintenance and the issue has no release label.

Risks & rollback

  • Primary review risk is merge conflict churn from the repository-wide baseline; the branch is currently one commit ahead and zero behind main.
  • Rollback is a single revert of 40996e4.

Changed files

  • .prettierignore — excludes dependencies, generated build/test output, runtime state, the lockfile, and hand-maintained Prettier configuration
  • 59 existing source, test, documentation, workflow-support, and configuration files — normalized mechanically by Prettier

Post-merge / human validation

  • None required beyond CI review of the repository-wide formatting check

Security

  • No real tokens, private keys, .env files, or generated installation tokens are committed

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 41.26% 42909 / 103981
🔵 Statements 41.26% 42909 / 103981
🔵 Functions 73.9% 2107 / 2851
🔵 Branches 79.37% 9924 / 12503
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/cli/src/commands/upgrade.ts 83.13% 86.48% 80% 83.13% 44-58, 78-79, 83-84, 178-185, 217-221
packages/cli/src/detection/environment-detector.ts 94.67% 89.25% 100% 94.67% 34-35, 49-50, 60-61, 200-204, 238-239, 245, 372-373, 388-389
packages/cli/src/workflow/workflow-runtime.ts 96.96% 91.66% 100% 96.96% 71-72, 82-83
packages/control-plane/client/src/main.tsx 0% 0% 0% 0% 1-35
packages/control-plane/client/src/components/Button.tsx 0% 100% 100% 0% 8-138
packages/control-plane/client/src/pages/FoundationsPage.tsx 0% 0% 0% 0% 1-71
packages/control-plane/client/src/routes/issues/$identifier.tsx 0% 0% 0% 0% 1-477
packages/core/src/domain/workspace.ts 100% 100% 100% 100%
packages/core/src/observability/fs-reader.ts 86.66% 81.81% 100% 86.66% 12-13, 24-25
packages/core/src/orchestration/retry-policy.ts 100% 100% 100% 100%
packages/core/src/runtime/mcp-compose.ts 90.44% 78.68% 100% 90.44% 41, 89, 141-142, 147-148, 159-160, 167-170, 174-175, 179, 207-208
packages/core/src/workspace/index.ts 100% 100% 100% 100%
packages/extension-github-workflow/src/approval-workflow.ts 0% 0% 0% 0% 1-323
packages/orchestrator/src/skills.ts 93.52% 88% 100% 93.52% 26, 31-32, 44-45, 126-127, 173-176
packages/runtime-claude/src/session-store.ts 82.17% 75% 100% 82.17% 55-56, 91-92, 99-102, 104-107, 110-111, 113-114, 120-121
packages/runtime-codex/src/convergence-detection.ts 92.5% 80% 100% 92.5% 41-45, 90
packages/worker/src/github-tracker.ts 100% 75% 100% 100%
packages/worker/src/host-dynamic-tool-call.ts 95.83% 50% 100% 95.83% 11
packages/worker/src/retry-policy.ts 100% 100% 100% 100%
packages/worker/src/workflow-lifecycle.ts 100% 100% 100% 100%
Generated in workflow #1547 for commit 40996e4 by the Vitest Coverage Report Action

@moncher-dev
moncher-dev marked this pull request as ready for review September 8, 2026 06:13
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-08T06:19:12.011874Z 40996e4 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 40996e4653

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +16 to +18
kind: github-project
provider:
project_id: PVT_REPLACE_WITH_YOUR_PROJECT_ID

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve nested workflow keys in the reference

When an agent copies this checked-in reference to author WORKFLOW.md, kind, provider, and project_id are now root-level YAML keys rather than children of tracker; the same flattening affects polling, workspace, hooks, agent, and codex. The workflow parser reads tracker.kind and tracker.provider, so the resulting configuration loses the selected adapter and its project ID. Keep the raw YAML indented, or exclude/restructure this mixed Markdown/YAML file so Prettier cannot flatten it.

AGENTS.md reference: AGENTS.md:L5-L7

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(format): restore repository-wide Prettier baseline

1 participant