Merged
Conversation
kasperisager
requested changes
Mar 2, 2026
bavulapati
reviewed
Mar 3, 2026
test/basic.js
Outdated
| test('copyBytesFrom', (t) => { | ||
| const u16 = new Uint16Array([0, 0xffff]) | ||
|
|
||
| Buffer.copyBytesFrom(u16)[0] = 42 |
Contributor
There was a problem hiding this comment.
To verify that a copy is actually made. If the function didn't copy the input buffer the assertions below would fail.
kasperisager
requested changes
Mar 3, 2026
index.js
Outdated
| if (offset || length) { | ||
| const sliceEnd = length ? (length += offset) : view.length | ||
|
|
||
| view = view.slice(offset, sliceEnd) |
Contributor
There was a problem hiding this comment.
slice() creates a copy as well so this will double copy the memory.
kasperisager
requested changes
Mar 3, 2026
Contributor
kasperisager
left a comment
kasperisager
left a comment
There was a problem hiding this comment.
Let's add some additional tests as well. Looks good now otherwise!
kasperisager
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References:
https://nodejs.org/api/buffer.html#static-method-buffercopybytesfromview-offset-length
https://github.com/nodejs/node/blob/f8d5bad52f6df23dab94cdca5e33e491b00efbfe/lib/buffer.js#L376