Skip to content

CMD + W closes currently opened Realm window - #1733

Draft
ajlamarc wants to merge 1 commit into
masterfrom
shortcuts-fixes
Draft

CMD + W closes currently opened Realm window#1733
ajlamarc wants to merge 1 commit into
masterfrom
shortcuts-fixes

Conversation

@ajlamarc

@ajlamarc ajlamarc commented Jun 2, 2023

Copy link
Copy Markdown
Contributor

Ticket: RE-205

Description

Basic hook into commands in Realm + prevent default behavior.

TODOs:

  • Alongside these lines, catch the fullscreen event with F11. Investigate toggling fullscreen and menubar simultaneously
  • Finish wiring up the "close current window" shortcut by creating a shell service and passing enabled + disabled over IPC to main
  • Design considerations: plan out followup work in RE-222. Is the current way of catching shortcuts good enough? Test accelerators again
  • We should consider overriding native MacOS shortcuts when Realm is in fullscreen (or kiosk mode only)

Reviewer Checklist

  • Pipeline passes
  • Docs have been added / updated
  • Tests have been added / updated
  • Has been refactored if necessary

@vercel

vercel Bot commented Jun 2, 2023

Copy link
Copy Markdown

Someone is attempting to deploy this pull request to the Holium Team on Vercel.

To accomplish this, the commit author's email address needs to be associated with a GitHub account.

Learn more about how to change the commit author information.

@ajlamarc
ajlamarc marked this pull request as draft June 2, 2023 14:40
@gdbroman

gdbroman commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

Not high priority, should we close this?

@ajlamarc

ajlamarc commented Jul 8, 2023

Copy link
Copy Markdown
Contributor Author

Not high priority, should we close this?

Going to leave this open as a draft for when we get around to shortcuts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants