Fix null_region meshgrid axis order#185
Merged
Merged
Conversation
ichristen
approved these changes
May 19, 2026
Collaborator
There was a problem hiding this comment.
Thanks for the catch. We actually already caught this on the dev branch common (ea96fb5), but it's good to fix now.
In experiment, we mostly use square (padded) farfields, and MRAF stuff has not yet been fleshed out in testing, so we previously missed this bug.
Speaking of square padded farfields, you might be able to get faster holography if you pad to a square power of two (or are you using a rectangular power of two for some reason?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shape of the mask didn't match the shape of the phase pattern because of numpy conventions.