Upgrade deCONZ to trixie - #4808
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe deCONZ add-on updates to version 8.8.0. Build images move from Debian Bookworm to Trixie. The Dockerfile installs Qt6 dependencies and downloads Qt6 Debian packages. Service scripts load the container environment and adjust TigerVNC startup. ChangesdeCONZ runtime migration
Estimated code review effort: 2 (Simple) | ~15 minutes Merge Risk: ⚪ Minimal · up to This upgrade does not have any identified merge-blocking risk at the current head and is ready after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
agners
left a comment
There was a problem hiding this comment.
Thanks for tackling this!
but a reinstallation of the app will likely be necessary.
If we can we should really avoid this. Hm, I see, in a local test with this applied, the VNC server fails to start:
[12:08:50] INFO: Websockify waiting for VNC to start
[12:08:50] INFO: Starting VNC server (local - yes)...
[10:08:51] WARNING: Halt app
With the help of Claude I found the root cause:
Debian jumps tigervnc 1.12 (bookworm) → 1.15 (trixie). In 1.13+ the user dir moved from ~/.vnc to ~/.config/tigervnc, and Debian's wrapper auto-migrates it (/usr/share/perl5/TigerVNC/Config.pm:1425-1435):
if (!(-d $opts->{'vncUserDir'})) { # ~/.config/tigervnc missing
if (!(-l $vncLegacyDir) && (-d $vncLegacyDir)) { # ~/.vnc exists
if (!mv($vncLegacyDir, $vncUserDir)) {
print STDERR "$PROG: Could not migrate ...\n";
exit 1;
mv can't create the parent. Your /data has .vnc but no .config at all.
Fresh /data works fine (exit 0) — which is precisely why mattreim's test install ran for days and why he assumed a reinstall was needed.
Add the following to the top of services.d/deconz/run should do the trick:
# tigervnc >= 1.13 migrates ~/.vnc to ~/.config/tigervnc, which needs ~/.config to exist
mkdir -p /data/.config
Btw, maybe also remove &> /dev/null from tigervncserver, that makes any future issues immeaditly visible.
Unrelated and pre-existing: The run scripts use #!/usr/bin/with-contenv bashio so they get TZ → local time (12:07 CEST). The finish scripts use plain #!/usr/bin/env bashio with no with-contenv, so no TZ → UTC (10:07). Same instant, different clock. Adding with-contenv to the finish scripts would make the logs consistent.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
@agners Thank you very much for the detailed troubleshooting and the suggested solutions. |
agners
left a comment
There was a problem hiding this comment.
Nice, other then the nit, looks good to me!
Co-authored-by: Stefan Agner <stefan@agner.ch>
As discussed here, I created a test version using Trixie and have been testing it without issues for several days now, but a reinstallation of the app will likely be necessary.
Summary by CodeRabbit
New Features
Improvements
Bug Fixes