Repository navigation
Brand images for bmx_monitor - #11242
Open
andystewart999 wants to merge 8 commits into
Open
andystewart999 wants to merge 8 commits into
andystewart999 wants to merge 8 commits into
Conversation
Brand images for imminent core submission
4 of 8 tasks
abmantis
requested changes
Sep 29, 2026
abmantis
left a comment
Member
There was a problem hiding this comment.
Is it possible to get an icon with transparent background instead of white?
Also, the 2x version is a bit blurry/pixelated. Can you add a better quality one?
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 馃憤 |
andystewart999
marked this pull request as ready for review
September 29, 2026 23:40
Contributor
Author
|
The hDPI version I think was generated by Google Images for the preview, but it does look better than the previous 2x version. If it isn't good enough I suggest we just do without it. Cheers, |
andystewart999
marked this pull request as draft
October 5, 2026 08:44
andystewart999
marked this pull request as ready for review
October 5, 2026 08:57
abmantis
approved these changes
Oct 6, 2026
Contributor
Author
|
Thanks for the approval @abmantis ! Much appreciated and thanks for your feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brand images for imminent core submission
Proposed change
As part of an upcoming core integration submission I've created this PR. Assuming the core submission is successful I'll raise another PR to remove the icons form /custom_components/ha_bm2monitor
Type of change
Additional information
There is no specific logo set of icons, so HA will fall back to the icons where necessary.
Checklist
icon.png)icon@2x.png)logo.png)logo@2x.png)