Bump roborock dependencies - #173766
Conversation
|
Hey there @Lash-L, @allenporter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Hey there @rdfurman, @mkmer, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull request overview
This PR bumps two roborock integration dependencies: python-roborock from 5.14.1 to 5.14.2 (fixing Q10 customized clean mode) and vacuum-map-parser-roborock from 0.1.4 to 0.1.5 (adding support for removed submaps). However, it also includes an unrelated AIOSomecomfort bump for the honeywell integration which should be in a separate PR.
Changes:
- Bumps
python-roborockto 5.14.2 andvacuum-map-parser-roborockto 0.1.5 in the roborock manifest and requirements_all.txt - Bumps
AIOSomecomfortfrom 0.0.35 to 0.0.36 for the honeywell integration (unrelated to PR scope)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| homeassistant/components/roborock/manifest.json | Updates roborock dependency versions |
| requirements_all.txt | Updates pinned versions for roborock and honeywell dependencies |
| homeassistant/components/honeywell/manifest.json | Unrelated bump of AIOSomecomfort dependency |
| "iot_class": "cloud_polling", | ||
| "loggers": ["somecomfort"], | ||
| "requirements": ["AIOSomecomfort==0.0.35"] | ||
| "requirements": ["AIOSomecomfort==0.0.36"] |
|
|
||
| # homeassistant.components.honeywell | ||
| AIOSomecomfort==0.0.35 | ||
| AIOSomecomfort==0.0.36 |
jpbede
left a comment
There was a problem hiding this comment.
There is a unrelated dependency bump of AIOSomecomfort and a test is failing. Could you please have a look?
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
6268f63 to
9a10c8e
Compare
jpbede
left a comment
There was a problem hiding this comment.
The now failing CI is unrelated.
Proposed change
Bump roborock dependencies:
python-roborock upstream links:
Changes in python-roborock 5.14.2:
vacuum-map-parser-roborock upstream links:
Changes in vacuum-map-parser-roborock 0.1.5:
Both are bug fixes in the libraries. No changes needed on the Home Assistant side.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: