tests: update Q10 cleaning mode test to include customized option - #174843
tests: update Q10 cleaning mode test to include customized option#174843lboue wants to merge 2 commits into
Conversation
YXCleanType gained a CUSTOMIZED member (code 4) in python-roborock 5.14.2 via Python-roborock/python-roborock#838. Update the expected options set to match.
|
Hey there @Lash-L, @allenporter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull request overview
This PR synchronizes a roborock test with an upstream library change. The python-roborock dependency added a new CUSTOMIZED member to YXCleanType, and the Q10 cleaning-mode select entity dynamically exposes all YXCleanType values (except UNKNOWN) as options. The test's expected options set is updated to match. It depends on the dependency bump in #174841.
Changes:
- Add
"customized"to the expected options set for the Q10 cleaning mode select entity test.
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Proposed change
YXCleanType gained a CUSTOMIZED member (code 4) in python-roborock 5.14.2 via Python-roborock/python-roborock#838. Update the expected options set to match.
Without this enum value, parsing raised a ValueError and produced conversion errors in logs.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: