Add Thread credential sharing to the Thread panel - #53330
Open
Poshy163 wants to merge 12 commits into
Open
Conversation
Add a button to the network card which asks the border router for a Thread Administration Passcode and shows it, with a QR code, so another border router can be given temporary access to the Thread network. Needs the otbr/create_ephemeral_key websocket command from core.
21 tasks
This was referenced Aug 13, 2026
8 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Adds UI support in the Thread configuration panel to request a Thread Administration Passcode (ephemeral key / ePSKc) from a border router and present it as both a manual code and QR code for credential sharing with another border router.
Changes:
- Add a “Share network credentials” action to the Thread network card, selecting a compatible border router when available.
- Introduce a new dialog to display the generated passcode and QR code, and revoke the ephemeral key when the dialog is closed.
- Extend OTBR frontend data layer with WebSocket helpers and types for creating/deleting ephemeral keys, plus new localization strings.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/translations/en.json |
Adds new localized strings for the credential sharing action, dialog, and error states. |
src/panels/config/integrations/integration-panels/thread/thread-config-panel.ts |
Adds the QR/share icon button and the handler that calls the OTBR WebSocket command and opens the new dialog. |
src/panels/config/integrations/integration-panels/thread/show-dialog-thread-ephemeral-key.ts |
Adds the dialog launcher (show-dialog fireEvent wrapper) for the new dialog. |
src/panels/config/integrations/integration-panels/thread/dialog-thread-ephemeral-key.ts |
Implements the dialog UI to show the passcode + QR code and revoke the ephemeral key on close. |
src/data/otbr.ts |
Adds OTBR ephemeral key WebSocket APIs and extends OTBRInfo with ephemeral_key_supported. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+487
to
+491
| title: this.hass.localize( | ||
| "ui.panel.config.thread.share_credentials_failed" | ||
| ), | ||
| text: err.message, | ||
| }); |
Author
|
The above is to stop this from occurring 
(now looks like this) 
|
Poshy163
marked this pull request as ready for review
August 22, 2026 13:02
github-actions
Bot
added
the
Needs Template
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Template
MindFreeze
reviewed
Aug 25, 2026
MindFreeze
reviewed
Aug 28, 2026
MindFreeze
left a comment
MindFreeze
left a comment
Member
There was a problem hiding this comment.
DialogMixin removes the element on close but keeps it in the dialog manager cache. On reopen, the same element is re-appended and connectedCallback() runs again, but _key, _error, and _secondsRemaining are not cleared first.
I added suggestions on where to clear them. There could be other/better places for it though.
| if (this._interval) { | ||
| window.clearInterval(this._interval); | ||
| this._interval = undefined; | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| } | |
| } | |
| this._secondsRemaining = undefined; |
| ephemeralKey | ||
| ).catch(() => { | ||
| // The key may already be expired or the router unreachable | ||
| }); |
Member
There was a problem hiding this comment.
Suggested change
| }); | |
| }); | |
| this._key = undefined; |
| // Revoke the code so it cannot be used after the dialog is gone | ||
| if (this._key && this._secondsRemaining !== 0) { | ||
| this._revoke(this._key.ephemeral_key); | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| } | |
| } | |
| this._error = undefined; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add a button to the network card which asks the border router for a Thread Administration Passcode and shows it, with a QR code, so another border router can be given temporary access to the Thread network.
Video
ePSKc.mp4
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed:
To help with the load of incoming pull requests: