Fix macOS verification and device classification, hide internal Windows disks - #85
Open
justanotherariel wants to merge 3 commits into
Open
Fix macOS verification and device classification, hide internal Windows disks#85justanotherariel wants to merge 3 commits into
justanotherariel wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #83. Three platform bug fixes, one commit each:
ddreads whole blocks, so the device checksum included stale bytes past the image end. Verification now hashes exactly the image length."sd"as a substring, which"ssd"contains — e.g. a "Samsung Portable SSD T7" got the SD-card type. "SD" now has to appear as its own word (SDHC/SDXC/microSD included); regression tests added.windows-skip-nonremovablediff.)Type of Change
Related Issues
Stacked on #83 (part of the #14 stack).
Testing
cargo test -p hai-core --features mockpasses on Linux; the macOS/Windows changes compile-check in CI. The macOS verify fix should get a real-hardware flash+verify before release.Screenshots
N/A — no UI changes.
Checklist
cargo fmtandnpm run lintDO NOT MERGE. After reviewing, merge #14 to merge all directly