Skip to content

feat: add middleware functionality in producers#82

Draft
cyberhck wants to merge 2 commits into
mainfrom
81-producer-middleware
Draft

feat: add middleware functionality in producers#82
cyberhck wants to merge 2 commits into
mainfrom
81-producer-middleware

Conversation

@cyberhck

@cyberhck cyberhck commented Mar 23, 2023 •
edited by jai
Loading

Copy link
Copy Markdown
Collaborator

Pull Request Submission Checklist

Please confirm that you have done the following before requesting reviews:

  • I have confirmed that the PR type is appropriate for the change I am making according to
    the Honest Pull Request and Commit Message Naming Conventions.
  • I have typed an adequate description that explains why I am making this change.
  • I have installed and run standard pre-commit hooks that lints and validates my code.

Description

  • initial draft of how the producer will look like.

This change is Reviewable

@cyberhck cyberhck requested a review from a team as a code owner March 23, 2023 11:25
@cyberhck cyberhck requested a review from bludot March 23, 2023 11:25
@cyberhck cyberhck changed the title 81 producer middleware feat: add middleware functionalities in middlewares Mar 23, 2023
@cyberhck cyberhck force-pushed the 81-producer-middleware branch from 596ab48 to 1669b68 Compare March 23, 2023 11:57
@sonarqubecloud

sonarqubecloud Bot commented Mar 23, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

62.5% 62.5% Coverage
0.0% 0.0% Duplication

@rohits1101 rohits1101 changed the title feat: add middleware functionalities in middlewares feat: add middleware functionalities in producers Apr 26, 2023
@cyberhck cyberhck changed the title feat: add middleware functionalities in producers feat: add middleware functionality in producers Apr 26, 2023
@cyberhck cyberhck marked this pull request as draft April 26, 2023 10:13
This was referenced Oct 17, 2023
Closed
Closed
bludot
bludot reviewed May 22, 2024
View reviewed changes

@bludot bludot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes pls pass ctx everywhere

@cyberhck

cyberhck commented Jun 11, 2025

Copy link
Copy Markdown
Collaborator Author

DO NOT MERGE, I want to change this, not completely happy with how this is looking like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bludot bludot bludot left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cyberhck @bludot