Open
Conversation
1. ClientErrorBoundary 래퍼 제거 - ErrorBoundary 직접 사용 2. AssetCategory 타입 통합 - domain 정의를 canonical로 통일 3. 장비 슬롯 배열 상수 추출 - EQUIPMENT_SLOT_LAYOUT 공유 4. Sort/Filter 제너릭 유틸 함수 추출 - entitySort.ts (18개 테스트) 5. Bearer 토큰 파싱 유틸 추출 - extractBearerToken() 6. Case 변환 함수 통일 - dataService에서 caseConverter import 테스트: 946개 전부 통과 (기존 928 + 신규 18) 빌드: 성공 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
ErrorBoundary직접 사용AssetSelectorDialog의 중복 정의 삭제, domain 버전으로 통일 (8 vs 6 카테고리 불일치 해소)EQUIPMENT_SLOT_LAYOUT공유 상수 생성 (2곳 중복 해소)entitySort.ts생성 (genericSort,genericSearch,toggleSortDirection) + 18개 테스트extractBearerToken()함수로 4곳 중복 해소dataService.ts로컬 함수 삭제,caseConverter.ts에서 importTest plan
🤖 Generated with Claude Code