fix(postgres): cast NUMERIC columns to TEXT for sqlx decode #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #63. PostgreSQL NUMERIC/DECIMAL columns could not be decoded by sqlx without the bigdecimal feature. The previous .try_get().ok() pattern silently converted decode errors to null, causing Arrow to throw "Column is declared as non-nullable but contains null values". - Build explicit column list instead of SELECT * - Cast NUMERIC/DECIMAL columns to TEXT in query - Add try_get_with_warning helper for decode error logging - Add regression tests for NOT NULL and nullable NUMERIC columns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #63. Casts PostgreSQL NUMERIC/DECIMAL columns to TEXT in fetch queries so sqlx can decode them without the bigdecimal feature.
Test plan
test_postgres_fetch_numeric_not_null_columns- verifies NOT NULL NUMERIC columns worktest_postgres_fetch_numeric_nullable_columns- verifies nullable NUMERIC columns with NULL values work