Fix(routes): show full resolved path in spectator:routes output - #222
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the spectator:routes command output to display the fully resolved (path-prefixed) operation path—matching what the command uses when comparing OpenAPI operations to Laravel routes—so the displayed “Path” is no longer confusing when spectator.path_prefix is configured.
Changes:
- Switch
spectator:routestext table output to show the resolved (prefixed) path instead of the raw spec path. - Switch
spectator:routesJSON output (spec_operations[].path) to emit the resolved (prefixed) path. - Add a console test asserting the JSON output includes the configured prefix in the displayed path.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Console/RoutesCommand.php | Uses the resolved (prefixed) operation path for both text and JSON output. |
| tests/Console/RoutesCommandTest.php | Adds a regression test for prefixed path display in JSON output. |
Comment on lines
224
to
229
| foreach ($specOps as $op) { | ||
| $rows[] = [ | ||
| $op['matched'] ? '<fg=green>matched</>' : '<fg=red>unimplemented</>', | ||
| $op['method'], | ||
| $op['path'], | ||
| $op['resolved'], | ||
| ]; |
Owner
|
Merged and shipped in v3.0.4. Nice consistency fix — the mismatch between the matched-routes column and the undocumented-routes column with a prefix set was definitely confusing. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When running
spectator:routeswith a configuredpath_prefix(or--prefixfilter), the table displayed the raw spec path (/files) instead of the actual path used for matching against Laravel routes (/api/v4/files). This was inconsistent with the undocumented rows, which already showed the full URI, and made the output confusing when a prefix was in play.The fix swaps the displayed value from the raw spec path to the resolved path in both the text table and JSON output.
Before
After