Widen cebe/php-openapi to ^1.7 for PHP 8.5 / Symfony 8 support - #225
Merged
Conversation
Upstream cebe/php-openapi 1.8.0 caps symfony/yaml at ^7 and emits
implicit-nullable deprecations on PHP 8.5. Widening to ^1.7 lets
Symfony 8 / PHP 8.5 users opt into devizzent/cebe-php-openapi (which
declares replace: {cebe/php-openapi: 1.7.0}) without forcing the fork
on everyone else — Spectator only touches classes present in both.
Closes #224
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011zRSy9QqthUcMpLQUKCqgP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cebe/php-openapiconstraint from^1.8→^1.7. The devizzent fork declaresreplace: {cebe/php-openapi: 1.7.0}, so downstream users on PHP 8.5 / Symfony 8 cancomposer require devizzent/cebe-php-openapito escape the upstreamsymfony/yaml ^7cap and implicit-nullable deprecations, while everyone else keeps resolving upstream cebe 1.8.0. Spectator only touches classes present in both packages, so no code change is needed.8.5to the tests CI matrix.Closes #224
Test plan
phpunit(260 tests) passes on PHP 8.4 with upstream cebe 1.8.0phpunit(260 tests) passes on PHP 8.4 with devizzent/cebe-php-openapi 1.1.5 (verified via a temporarycomposer require)cebe/php-openapi: ^1.7+devizzent/cebe-php-openapi: ^1.1resolves to the fork and pullssymfony/yaml v8.1.5phpstanclean🤖 Generated with Claude Code
https://claude.ai/code/session_011zRSy9QqthUcMpLQUKCqgP