Fix the release build: modern compiler on macOS, correct arch under Rosetta - #4
Merged
Conversation
The first real release run failed on macOS: the runner ships AppleClang 15, which lacks Class Template Argument Deduction for aggregates, and src/util/overloaded.h requires it. Rather than chase whichever Xcode a runner image happens to carry, build with Homebrew's LLVM, which is current everywhere. Apple silicon also moves to macos-15. Also fixes a defect the failure led me to: the console picked its prebuilt architecture from platform.machine(), which reports the *interpreter's* architecture. A Python running under Rosetta on Apple silicon says x86_64, so an M-series Mac would have fetched an Intel node. It now asks the kernel whether the process is translated and answers for the hardware — verified on an M1 Pro, where platform.machine() says x86_64 and the corrected check says arm64. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first tagged release run failed. Two fixes.
1. macOS artifacts would not compile. The runner ships AppleClang 15, which lacks CTAD for aggregates — required by
src/util/overloaded.h. Build with Homebrew LLVM instead of depending on the runner's Xcode vintage; Apple silicon also moves tomacos-15.2. Wrong architecture under Rosetta. Chasing the first bug surfaced a second: the console chose its prebuilt slug from
platform.machine(), which reports the interpreter's architecture. A Python running under Rosetta on Apple silicon reportsx86_64, so an M-series Mac would have downloaded an Intel node.Verified on an M1 Pro:
platform.machine()returnsx86_64, the corrected check returnsarm64. The shell installer already useduname -mand was unaffected.Checklist
python3 -m py_compile contrib/vibes/bitcoin-vibessrc/untouched — consensus unaffected