Fix restoring a visit without a cached snapshot available - #368
Conversation
|
I think this "breaks" the intended behaviour when navigating Back from a same-page anchor with turbo caching disabled 🥴 E.g.
There won't be a cached snapshot, so it'll make a request, even though it should just jump back :/ |
|
Hmmm, that is a dilemma 🤔. Let me think about this a bit more. The existing behavior breaks the native apps, so we definitely need to address that aspect. |
|
I'm not familiar with Android logs, so I'm not sure I understand the problem. Could you describe the flow that is causing the error? |
|
@domchristie I've outlined the issue here: hotwired/turbo-android#185 I was actually able to resolve the issue in the Android library and the iOS library isn't affected by this bug, so there shouldn't need to be any additional changes necessary here. Let me know if that doesn't make sense or you have any questions. Thanks! |
There may not always be a cached snapshot available when restoring a visit. We need to issue a new request in that situation.
This fixes a regression from #298. Bug report here: hotwired/turbo-android#184
cc @domchristie