Fixes for Node 12 and various other changes for maintenance #62
Open
RobertLowe wants to merge 8 commits intohoverinc:masterfrom
Open
Fixes for Node 12 and various other changes for maintenance #62RobertLowe wants to merge 8 commits intohoverinc:masterfrom
RobertLowe wants to merge 8 commits intohoverinc:masterfrom
Conversation
- Fixes all jest tests - Fixes various require statements to import - Fixes docusaurus by locking version - Changes `takeSnapshot` functions to `compareSnapshot` - Changes related phrases for take to compare - Replaces `When` for compare with `Then`, its only an assertion, even though there is a side effect of saving snapshots Remaining work: Resolve cypress tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
takeSnapshotfunctions tocompareSnapshotWhenfor compare withThen, its only an assertion, even though there is a side effect of saving snapshotsLet me know your thoughts