Join the marketing footer to the network footer band; release v0.24.0 - #104
Merged
Merged
Conversation
A marketing footer directly followed by the shared network footer (.hraness-site-footer) now reads as one band instead of two stacked bars: the product row's bottom space collapses to a compact gap and the network row's content follows the marketing measure and gutter through the documented --hraness-site-footer-measure seam, so both registers share one column at every width. Both landmarks and both edges stay; only the double spacing and column drift go away. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Product sites that mount
MarketingSiteFooterfollowed by the@hraness/site-footernetwork footer render two stacked bars today. This release joins the pair into one band through two adjacency rules inproduct-marketing.css:.hraness-marketing-footer:has(+ .hraness-site-footer)collapses the product row's2rem 4rembottom space to2rem 1.25rem, so the two registers read as one band..hraness-marketing-footer + .hraness-site-footersets the footer's documented--hraness-site-footer-measureseam tomin(100%, measure) - 2 * gutter, which makes the network row's content land on the marketing column edge at every width.Both landmarks, the product row's top rule, and the network row's hairline stay; only the double spacing and column drift go away. The seam is CSS-only: no props, no markup contract changes, and it reaches standalone, compiled, and compiler-adopter consumers through the existing stylesheets.
Requires
@hraness/site-footerv0.20.0for the in-flow footer; older pins keep working unchanged.Test plan
bun run check— lint, typecheck, build, StyleX artifact + determinism gates, package smoke, 505 tests, all browser suites#v0.24.0+#v0.20.0in follow-upsGenerated with Devin