Add evidence blocks to the marketing grammar - #106
Merged
Merged
Conversation
3 tasks
0thernet
force-pushed
the
task/marketing-evidence-layout
branch
from
September 28, 2026 05:15
7b0a9b5 to
1043e85
Compare
MarketingDataTable and MarketingCodeBlock give product pages a shared way to publish dated measurements and runnable commands: captioned tables with numeric columns, cell tones, an honest caveat note, and internal scroll containment; code blocks that carry the shared syntax highlighting and stay inside the measure. The grammar also closes the containment gap that let unowned direct children of MarketingPage escape the measure, and fixes raw-CSS resets (blanket margin: 0) that silently defeated the shared auto-margin measure in non-compiled delivery. Compiled atoms now leave text-align to the [data-numeric] grammar rule so attribute hooks work identically in both delivery modes. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
0thernet
force-pushed
the
task/marketing-evidence-layout
branch
from
September 28, 2026 05:25
1043e85 to
9357150
Compare
0thernet
enabled auto-merge (squash)
September 28, 2026 05:25
0thernet
added a commit
to hraness/gobstopper
that referenced
this pull request
Sep 28, 2026
The previous quiet rewrite shipped unstyled hooks and bypassed the design system: the proof figure broke the measure with a raw pre block, benchmark tables had no numeric alignment or containment, and README-derived code rendered without syntax highlighting. The homepage now composes MarketingDataTable for the resume-trial evidence — a captioned, dated table with numeric columns, tone marks, and an honest caveat — plus MarketingCodeBlock for install commands. Docs, benchmarks, methodology, and compare routes render through a shared SiteDocument that emits the embedded plain-publication grammar, so measure, contents navigation, tables, and highlighted code are owned by the design kit rather than per-page CSS. The bespoke document-page stylesheet is removed; readme-html now passes fenced blocks through the shared highlighter. Pins @hraness/design-kit to the evidence-grammar commit (hraness/design-kit#106); update to its release tag once cut. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
0thernet
added a commit
to hraness/gobstopper
that referenced
this pull request
Sep 28, 2026
The previous quiet rewrite shipped unstyled hooks and bypassed the design system: the proof figure broke the measure with a raw pre block, benchmark tables had no numeric alignment or containment, and README-derived code rendered without syntax highlighting. The homepage now composes MarketingDataTable for the resume-trial evidence — a captioned, dated table with numeric columns, tone marks, and an honest caveat — plus MarketingCodeBlock for install commands. Docs, benchmarks, methodology, and compare routes render through a shared SiteDocument that emits the embedded plain-publication grammar, so measure, contents navigation, tables, and highlighted code are owned by the design kit rather than per-page CSS. The bespoke document-page stylesheet is removed; readme-html now passes fenced blocks through the shared highlighter. Pins @hraness/design-kit to the evidence-grammar commit (hraness/design-kit#106); update to its release tag once cut. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
0thernet
added a commit
to hraness/gobstopper
that referenced
this pull request
Sep 28, 2026
## Summary Rebuilds the site on the shared design-kit grammar instead of the bespoke quiet-presentation markup that shipped unstyled hooks. - Homepage: `MarketingDataTable` presents the resume-trial evidence as a captioned, dated table with numeric columns and an honest caveat; `MarketingCodeBlock` gives install/inspect commands shared syntax highlighting; sections compose the marketing grammar (`ProductHero`, `MarketingFlow`, `MarketingInterfaceGrid`, `MarketingPrimitives`, `MarketingTrustBoundary`, `MarketingInstallPanel`, `MarketingQuestionList`, `MarketingMaker`, `MarketingRelated`) with no site-owned layout classes. - Docs, benchmarks, methodology, and compare routes render through a shared `SiteDocument` emitting the embedded `plain-publication` grammar — contents nav, measure, styled tables, and highlighted code are owned by the design kit, separating reference documents from the marketing composition. - `readme-html.ts` passes fenced code blocks through the shared highlighter, so README-derived docs get syntax highlighting. - `globals.css` drops the bespoke `.document-page` stylesheet; remaining rules are intentional site-owned hooks (`gob-agent-marks`, `gob-doc-marks`, `install-note`) plus host-level block spacing for embedded publications. - Tests updated for syntax-tokenized markup (assertions strip tags before comparing command text). **Dependency:** `@hraness/design-kit` is pinned to `a4e30f1` — the merged hraness/design-kit#106 commit on main (post-v0.25.0). A follow-up can move to the release tag once a release containing it is cut. #### Test plan - [x] `bun run check` — theme snapshots, readme/blog sync, 45 unit tests, lint, typecheck, `next build`, built-site runtime tests — all against the real pinned commit - [x] Playwright at 1280px and 375px on `/`, `/benchmarks`, `/docs`, `/compare/*`: zero page-level horizontal overflow; benchmark table scrolls only inside its ruled region; README code blocks render syntax-highlighted - [x] `scrollWidth === innerWidth` at both widths on all six audited routes Generated with [Devin](https://devin.ai) Co-authored-by: 0thernet <894119+0thernet@users.noreply.github.com> Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MarketingDataTable: a captioned, dated evidence table for product pages — numeric column alignment viadata-numeric, positive/negative cell tones viadata-tone, an honest caveatnote, and a bounded internal scroll region so wide tables never cause page-level overflow.MarketingCodeBlock: a shared<pre>wrapper overSyntaxCodeso every consumer page gets syntax highlighting by default.MarketingPagenow inherit the shared measure instead of escaping to full bleed — the class of layout bug that produced clipped/full-width content on consumer sites..hraness-marketing-proof-frame { margin: 0 }(specificity 0,1,0) silently defeated the:where()group'smargin-inline: autoin non-compiled delivery, while compiled atoms applied it. Raw rules now usemargin-block: 0, and atoms no longer settext-alignwhere thedata-numericgrammar must win — the browser suite's 72 delivery-vs-oracle mismatches are resolved to 0.MARKETING_COPY.mddocuments the new slots (caption = the measurement's name, note = the caveat that bounds the claim).Test plan
bun run check— lint, typecheck, build, StyleX artifact parity + determinism, package smoke, 287 unit tests, full browser matrix (raw / projected / standalone / compiler-foundation)Generated with Devin