This repository was archived by the owner on Sep 19, 2026. It is now read-only.
Repository navigation
ci: split giant test files and the remainder lane by measured durations - #263
Merged
Merged
Conversation
Two files dominated the source matrix: state-store.test.ts (~16min of a
28min shard) and daemon/service.test.ts (~14.5min of a 22min shard).
Bun round-robin file assignment spreads part files across shards, so
splitting them 4- and 3-ways balances the matrix to ~10-14min per shard
without changing shard count or the runner contract.
- scripts/split-giant-tests.py: char-level statement scanner that never
cuts inside strings, comments, or template literals (including nested
${}), hoists top-level + describe-local helpers into shared testkits
under scripts/fixtures/, re-anchors import.meta.dir joins and relative
module specifiers for the new location, and chunks only at
test/describe/for boundaries. Every test name is preserved verbatim.
- Emit state-store-{1..4}.test.ts and service-{1..3}.test.ts plus their
testkits; originals keep only non-giant describes.
- eslint.config.mjs: extend the test-code override to *-testkit.ts.
- Split check:ci-remainder into checks vs suites sub-lanes (the coverage
contract holds because the aggregate expands to the same ordered set);
ci.yml gains a parallel remainder-checks lane.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/storage/state-store.test.tsalone ran ~16min inside a 28min shard-4;src/daemon/service.test.ts~14.5min inside a 22min shard-2. Bun assigns files round-robin across the 6 shards, so splitting the giants rebalances the matrix without touching shard count or the runner contract.scripts/split-giant-tests.py: char-level statement scanner (never cuts inside strings/comments/template literals incl. nested${}), hoists top-level and describe-local helpers into sharedscripts/fixtures/*-testkit.ts, re-anchorsimport.meta.dirjoins and relative module specifiers, chunks only at test/describe/for boundaries. All test names preserved verbatim — verified identical name sets.state-store-{1..4}andservice-{1..3}part files; originals keep only their non-giant describes.check:ci-remaindersplit intocheck:ci-remainder-checksandcheck:ci-remainder-suitessub-lanes; the coverage contract still holds because the aggregate recursively expands to the same ordered command set.ci.ymlgains a parallelremainder-checkslane.eslint.config.mjs: test-code override extended toscripts/fixtures/*-testkit.ts.Test plan
bunx tsc --noEmitclean;eslintclean on all emitted filesbun testservice suite: 596/596 pass; state-store suite: 721 pass + 1 fail (import.meta.dir re-anchor bug in generated status-reader child) → fixed and re-verified standalonerelease-workflow.test.tscontract: 33/33 pass