Source web icons from the vetted design-kit library - #262
Merged
Merged
Conversation
renderFrame resolves when authored callbacks return, not when the new surface reaches the compositor. Under heavy GPU load a screenshot taken immediately can capture the previous presented frame — observed downstream as stills containing the prior seek pixels. Wait two animation frames between renderFrame and the screenshot so every capture reflects the frame it is named for. Also records a kb note collecting the deterministic scene-authoring pitfalls this class of bug belongs to (shader NaN domain guards, presentation ordering, additive-only glow layers, edge-on backdrops, seek-stability, disc orientation, uniform declaration). Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
The two-requestAnimationFrame presentation barrier can wait forever on BeginFrame-controlled headless runtimes (chromium-headless-shell): frames are only produced on embedder request, so an idle page's callbacks never fire and the 60s step timeout trips. A cheap throwaway 1x1 screenshot forces one BeginFrame/present and lets the queued draw land, then the real capture reads the fresh surface in every headless mode. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Bumps @hraness/design-kit to v0.22.0 for apps/web and vendors the slopcamera icon set (5 illustrations + served shared anchors + the product mark) from the pinned package via scripts/sync-icons.ts; a parity test byte-compares the vendored files against the package. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Vercel installs apps/web with --frozen-lockfile against its own lockfile. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
# Conflicts: # apps/desktop/cli/html-overlay-renderer.macos.test.ts # apps/web/bun.lock # apps/web/package.json # apps/web/scripts/build-site.ts # apps/web/scripts/site-contract.test.ts # apps/web/scripts/site-contract.ts # apps/web/site.test.ts # bun.lock
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@hraness/design-kittov0.22.0inapps/weband vendor the vettedslopcameraicon set intosrc/icons//src/marks/from the pinned package.apps/web/scripts/sync-icons.tsrewrites the vendored copies and refuses undeclared files;scripts/sync-icons.test.tsbyte-compares every served icon against the package.Test plan
bun run sync:iconsreproduces the vendored setbun test scripts/sync-icons.test.ts— parity with the package bytesGenerated with Devin