Skip to content

test: give Codex account close retry a realistic deadline - #529

Merged
0thernet merged 1 commit into
mainfrom
fix/codex-account-close-timing-c0681c55
Oct 17, 2026
Merged

0thernet merged 1 commit into
mainfrom
fix/codex-account-close-timing-c0681c55

Conversation

@0thernet

Copy link
Copy Markdown
Member

What changed

  • Keep the dispatched-login abort/timeout tests' first close fail-closed while the login is held, but give the post-release retry a 1000 ms deadline rather than 5 ms.
  • Add a controlled-clock regression showing that exhausting the close deadline immediately after releasing the login still retains the lease; only a later fully proven close releases it once.
  • This is a test-only change; account lease/release behavior in src/ is unchanged. The synthetic reproduction identifies a plausible timing mechanism, not a confirmed root cause of Bump actions/setup-node from 7.0.0 to 7.1.0 #521's runner failure.

Verification

  • bun test test/codex-account.test.ts --rerun-each=5 (310/310 passed)
  • bun run check:versions, bun run typecheck, bun run check:convex, bun run build:dist, and bun run check:package passed.
  • bun run check was attempted but this OS-confined native executor denies Unix-socket listening in unrelated egress/driver tests (206 failures). CI's Compatibility package and Required checks on the PR are the supported-environment gate; do not bypass them.

Related: #521 (its separate Dependabot branch is not changed here).

@vercel

vercel Bot commented Oct 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
xcb Ignored Ignored Oct 17, 2026 5:19pm UTC

Request Review

@0thernet
0thernet enabled auto-merge (squash) October 17, 2026 17:19
@0thernet
0thernet merged commit e930cf3 into main Oct 17, 2026
19 checks passed
@0thernet
0thernet deleted the fix/codex-account-close-timing-c0681c55 branch October 17, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant