Dev#1
Open
hrsweetlana wants to merge 15 commits into
Open
Conversation
|
Please add description to your pull request |
Anderwerty
reviewed
Feb 27, 2024
|
|
||
| public class BruteForceDecription { | ||
| CaesarCipher caesarCipher; | ||
| Map letterFrequency; |
There was a problem hiding this comment.
Sorry, but why do we use raw-type for generic type Map?
Anderwerty
reviewed
Feb 27, 2024
| public class BruteForceDecription { | ||
| CaesarCipher caesarCipher; | ||
| Map letterFrequency; | ||
| List<Character> alphabet; |
Anderwerty
reviewed
Feb 27, 2024
| import java.util.List; | ||
|
|
||
| public class CaesarCipher { | ||
| public List<Character> getAlphabet() { |
There was a problem hiding this comment.
The getter should be after the constructor. But do we really need this getter? Functionality of this class should cover all you need to get from alphabet
Anderwerty
reviewed
Feb 27, 2024
| private static String filePath = ""; | ||
| private static String option = ""; | ||
| private static String key = ""; | ||
| private static FileCrypter fileCrypter; |
There was a problem hiding this comment.
Why do we need these static fields? We can use local variables instead of these static fields.
Anderwerty
reviewed
Feb 27, 2024
| 'V', 'W', 'X', 'Y', 'Z', 'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i', 'g', 'k', 'l', 'm', 'n', 'o', 'p', | ||
| 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z', '.', ',', '«', '»', '"', '\'', ':', '!', '?', ' '}; | ||
|
|
||
| // public static final Character[] ENGLISH_ALPHABET = new Character[]{ |
There was a problem hiding this comment.
Do we need a commented code? If we need it please uncomment it, if no - remove it.
Anderwerty
reviewed
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.