fix: address CodeRabbit review — error handling, displayName, progress math#69
Conversation
…edge case, progress math hardening Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
Addresses the 3 CodeRabbit review comments from PR #68:
handleSignOuterror handling — wrappedsignOut(auth)in try-catch so network/Firebase failures don't crash the component.navigate("/")only runs on success.displayNameinitials edge case — added.filter((n) => n.length > 0)before.map((n) => n[0])so consecutive spaces indisplayName(e.g."John Doe") don't produceundefinedin the initials string.overallProgresshardening — null-safeproject.stages ?? {}access,Number.isFinitevalidation on eachcompletionPercent, and divide-by-zero guard whenstageValues.length === 0.Link to Devin session: https://app.devin.ai/sessions/3cc968b3f6af4fc09059e162d7190a95
Requested by: @hrx01-dev