Skip to content

fix: address CodeRabbit review — error handling, displayName, progress math#69

Merged
hrx01-dev merged 1 commit into
devin/1781966337-client-dashboardfrom
devin/1781968928-coderabbit-fixes
Jun 20, 2026
Merged

fix: address CodeRabbit review — error handling, displayName, progress math#69
hrx01-dev merged 1 commit into
devin/1781966337-client-dashboardfrom
devin/1781968928-coderabbit-fixes

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Summary

Addresses the 3 CodeRabbit review comments from PR #68:

  1. handleSignOut error handling — wrapped signOut(auth) in try-catch so network/Firebase failures don't crash the component. navigate("/") only runs on success.

  2. displayName initials edge case — added .filter((n) => n.length > 0) before .map((n) => n[0]) so consecutive spaces in displayName (e.g. "John Doe") don't produce undefined in the initials string.

  3. overallProgress hardening — null-safe project.stages ?? {} access, Number.isFinite validation on each completionPercent, and divide-by-zero guard when stageValues.length === 0.

Link to Devin session: https://app.devin.ai/sessions/3cc968b3f6af4fc09059e162d7190a95
Requested by: @hrx01-dev

…edge case, progress math hardening

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a9669e5c-2676-4d52-8e21-2ca6318afac6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch devin/1781968928-coderabbit-fixes

Comment @coderabbitai help to get the list of available commands and usage tips.

@hrx01-dev hrx01-dev self-requested a review June 20, 2026 15:24
@hrx01-dev hrx01-dev self-assigned this Jun 20, 2026
@hrx01-dev hrx01-dev merged commit 5c982c0 into devin/1781966337-client-dashboard Jun 20, 2026
2 checks passed
@hrx01-dev hrx01-dev deleted the devin/1781968928-coderabbit-fixes branch June 21, 2026 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant