Skip to content

Revert "reduce the time of prerender screen for better seo and crawbility"#87

Merged
hrx01-dev merged 1 commit into
mainfrom
revert-42-vite-plugin-ssg
Jun 20, 2026
Merged

Revert "reduce the time of prerender screen for better seo and crawbility"#87
hrx01-dev merged 1 commit into
mainfrom
revert-42-vite-plugin-ssg

Conversation

@hrx01-dev

@hrx01-dev hrx01-dev commented Jun 20, 2026

Copy link
Copy Markdown
Owner

Reverts #42

Summary by CodeRabbit

  • Refactor

    • Simplified app initialization and build process by removing the prerender step.
    • Removed static prerendering capability for improved build efficiency.
  • Chores

    • Removed prerendering build dependency from development packages.

@hrx01-dev hrx01-dev self-assigned this Jun 20, 2026
@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f533d0b9-5a76-42ab-bb5b-0d2f9719d4df

📥 Commits

Reviewing files that changed from the base of the PR and between 3ea51c8 and 9611805.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • package.json
  • scripts/prerender.js
  • src/main.tsx

📝 Walkthrough

Walkthrough

The PR removes the Puppeteer-based prerender script (scripts/prerender.js) entirely, strips the node scripts/prerender.js step from the build script in package.json, removes the puppeteer devDependency, and simplifies src/main.tsx by removing the BrowserRouter wrapper and the conditional null-check around the root mount.

Changes

Prerender Pipeline Removal

Layer / File(s) Summary
Build script and dependency cleanup
package.json
build script reduced to vite build only; puppeteer devDependency removed; scripts/prerender.js deleted (161 lines: HTTP server, Puppeteer launch, route rendering, HTML write-back, and cleanup logic).
React entry point simplification
src/main.tsx
BrowserRouter wrapper and conditional null-check removed; App is now rendered directly via createRoot(document.getElementById("root")!).render(<App />).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • hrx01-dev/Servio#41: Directly related — that PR added the BrowserRouter wrapper to src/main.tsx which this PR removes.
  • hrx01-dev/Servio#42: This PR effectively reverts the SEO pre-rendering setup introduced there, including scripts/prerender.js, the Puppeteer dependency, and the src/main.tsx changes.

Poem

🐇 Hop hop, the prerender is gone,
No Puppeteer browser to spawn!
Just vite build alone,
No scripts to bemoan —
A simpler path to carry on! 🌿

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-42-vite-plugin-ssg

Comment @coderabbitai help to get the list of available commands and usage tips.

@hrx01-dev hrx01-dev merged commit 430d5f8 into main Jun 20, 2026
1 of 4 checks passed
kumudranjan6127-debug added a commit to kumudranjan6127-debug/Servio that referenced this pull request Jun 20, 2026
…d @google/generative-ai

upstream/main added AI estimation (PR hrx01-dev#83) and admin RBAC (PR hrx01-dev#82) and
reverted the broken vite-plugin-ssg prerender step (PR hrx01-dev#87).

DashboardLayout conflict resolved: keep our Moon/Sun theme toggle imports
alongside upstream's Sparkles/Settings2 for the new nav items.

Install @google/generative-ai@^0.24.1 required by the new estimationService.

Closes hrx01-dev#71 — theme toggle is already implemented in both the sidebar and
mobile header of DashboardLayout; this merge makes it available to all
authenticated users on the latest codebase.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@hrx01-dev hrx01-dev deleted the revert-42-vite-plugin-ssg branch June 21, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant