Skip to content

Fix: Deployment issue#88

Merged
hrx01-dev merged 1 commit into
mainfrom
fix/deployment-issue
Jun 21, 2026
Merged

Fix: Deployment issue#88
hrx01-dev merged 1 commit into
mainfrom
fix/deployment-issue

Conversation

@hrx01-dev

@hrx01-dev hrx01-dev commented Jun 21, 2026

Copy link
Copy Markdown
Owner

Description

Due to the changes in the toggling theme PR , there comes a deployment issue . This PR tends to fix that

Summary by CodeRabbit

  • Refactor
    • Modified splash screen behavior to display only on the landing page, allowing other routes to load faster with improved initialization performance.

@hrx01-dev hrx01-dev self-assigned this Jun 21, 2026
@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a4d2fa4b-4e3b-4e09-a5f0-c9d364b398fe

📥 Commits

Reviewing files that changed from the base of the PR and between 61c5fe4 and bc81e11.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • src/app/App.tsx

📝 Walkthrough

Walkthrough

LandingShell is narrowed to render only <LandingPage /> inside its splash-reveal region. App now owns the full BrowserRouter, ThemeProvider, AuthProvider, and Routes tree, gating only the / path behind LandingShell. Dashboard nested routes gain explicit estimation and pricing-config sub-routes.

Changes

Splash Gate Scoped to Landing Route

Layer / File(s) Summary
Provider/router lift and route reorganization
src/app/App.tsx
LandingShell is reduced to mounting only <LandingPage /> inside its animated motion.div. App moves ThemeProvider, AuthProvider, ScrollToTop, and Routes outside the splash shell; routing gates only path="/" behind LandingShell while /signin, /signup, /admin/*, /services/:slug, and /dashboard (with new estimation and pricing-config nested routes) render directly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • hrx01-dev/Servio#41: Also modifies src/app/App.tsx routing and Landing* composition, overlapping directly with the route structure changes here.

Suggested labels

bug

Poem

🐇 Hop hop, the splash now guards just one small door,
The rest of the app need not wait anymore!
Providers climb up, free from loading's gate,
Dashboard routes branch out — estimation's great!
A tidy tree of routes, no tangled vine,
This bunny's burrow now has clean design. 🌿

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/deployment-issue

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit bc81e11):

https://servio-0--pr88-fix-deployment-issue-rw8bcvzy.web.app

(expires Sun, 28 Jun 2026 08:17:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 15915abb5951eb298a844eda460b24f444d93a69

@hrx01-dev hrx01-dev merged commit 8c64409 into main Jun 21, 2026
5 of 6 checks passed
@hrx01-dev hrx01-dev deleted the fix/deployment-issue branch June 21, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant