Conversation
Author
|
This was discovered during testing of PR #1034. It broke the build on Linux. This fix needs to be merged before the fix requested in PR #1034. This fix has been tested in Windows and Linux. @fcr would you perform a build on MacOS to confirm that this fix does not break anything? |
Collaborator
|
Okay @dkeeney, it builds and passes all unit tests on MacOS |
Author
|
Cool. @fcr, I am merging this PR into the master and then I will merge your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build process was trying to install gmock and it is not being used.
The solution is to set variables in the googletest download to prevent installing.