Fix init permanence distance from connected threshold: TM, SP#889
Open
Fix init permanence distance from connected threshold: TM, SP#889
Conversation
"close" measured in the number of needed permanence inc/dec steps. Not initializing close leads to suboptimal functionality.
Member
Author
|
There's a number of tests that are expected to fail and I'll have to update them. But the essence of the PR is here. |
dkeeney
reviewed
Sep 14, 2020
dkeeney
left a comment
There was a problem hiding this comment.
I see no obvious problems. I cannot judge on the algorithm.
This would be nice, since it is simplification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TM initial and connected synaptic weights were mistakenly (by our changes in the past) initialized too far away. The intention was/is to init close to the edge of "connected".
This is a minor PR, ready to go as is. Changes doublechecked on NAB, no improvement/worse.
PS: As a follow up, I'd like to simplify the synapse init logic:
connectedPermanenceand hardcode this value (empirically no difference in 0.2, 0.5)