Async handling; Controller protocol; Path/handler conveniences#526
Open
namolnad wants to merge 9 commits intohttpswift:stablefrom
Open
Async handling; Controller protocol; Path/handler conveniences#526namolnad wants to merge 9 commits intohttpswift:stablefrom
namolnad wants to merge 9 commits intohttpswift:stablefrom
Conversation
Author
|
(Worth noting there are some CI issues and OS version items that will need to be sorted out if these changes are desirable for others besides myself) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there 👋
This PR is mostly to gauge interest in a few changes I've made to a forked copy of this package. I can very easily split this up into many PRs if there is interest in any/all of this, but first wanted to see how it was received. Thanks for having a look!
Included Changes
a. Allows use of async/await to make async extremely simple
a. Noticed files within directories were broken
a. Slim out the package
a. Allows
GET["your/route"] = MyController.myRouteHandleri. The above would be possible for the following:
struct MyController: Controller { func myRouteHandler(_ request: HttpRequest) async -> HttpResponse {a. Allows
GET["my/first/route", "my_other_route"] = { request in }:from request parametersa. Allows
request["parameterName"]vsrequest[":parameterName"]as a more convenient/intuitive accessor.i. Addresses Strip ':' from param keys #489