Skip to content

added a function to handle decoding as utf-16 as a fallback if decodi… #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuanzhou merged 1 commit into from
Apr 15, 2026
Merged

added a function to handle decoding as utf-16 as a fallback if decodi… #917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2991,7 +2991,8 @@
file.filename = utils.secure_filename(file.filename)
file_location = commons_file_helper.ensureTrailingSlash(
app.config['FILE_UPLOAD_TEMP_DIR']) + temp_id + os.sep + file.filename
with open(file_location, newline='') as tsvfile:
tsvfile = open_tsv(file_location)
with tsvfile:
reader = csv.DictReader(tsvfile, delimiter='\t')
first = True
for row in reader:
Expand Down Expand Up @@ -3047,7 +3048,8 @@
tsvfile_name = tsv_directory + temp_file_name
records = []
headers = []
with open(tsvfile_name, newline='') as tsvfile:
tsvfile = open_tsv(tsvfile_name)
with tsvfile:
reader = csv.DictReader(tsvfile, delimiter='\t')
first = True
for row in reader:
Expand Down Expand Up @@ -3114,6 +3116,15 @@
return Response(json.dumps(response, sort_keys=True), status_code, mimetype='application/json')


def open_tsv(path):
try:
f = open(path, newline='', encoding='utf-8-sig')

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression

This path depends on a [user-provided value](1).
Comment thread
yuanzhou marked this conversation as resolved.
Dismissed
f.read()
f.seek(0)
except UnicodeDecodeError:
return open(path, newline='', encoding='utf-16')

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression

This path depends on a [user-provided value](1).
Comment thread
yuanzhou marked this conversation as resolved.
Dismissed


def validate_samples(headers, records, header):
error_msg = []
file_is_valid = True
Expand Down
Loading