Skip to content

Derek furst/open tsv fix #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuanzhou merged 2 commits into from
Apr 20, 2026
Merged

Derek furst/open tsv fix #919

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7438f6a
Merge pull request #918 from hubmapconsortium/Derek-Furst/fix-utf-bug
yuanzhou Apr 15, 2026
b02187d
hotfix. occasionally returning open() object equal to Nonetype
DerekFurstPitt Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3118,9 +3118,14 @@

def open_tsv(path):
try:
f = open(path, newline='', encoding='utf-8-sig')
f.read()
f.seek(0)
f = open(path, newline='', encoding='utf-8-sig')

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression

This path depends on a [user-provided value](1).
Comment thread
yuanzhou marked this conversation as resolved.
Dismissed
try:
f.read()
f.seek(0)
return f
except UnicodeDecodeError:
f.close()
return open(path, newline='', encoding='utf-16')

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression

This path depends on a [user-provided value](1).
Comment thread
yuanzhou marked this conversation as resolved.
Dismissed
except UnicodeDecodeError:
return open(path, newline='', encoding='utf-16')

Expand Down
Loading