Notification updates, fix get_globus_url, small updates#1236
Merged
jpuerto-psc merged 16 commits intodevelfrom Apr 30, 2026
Merged
Notification updates, fix get_globus_url, small updates#1236jpuerto-psc merged 16 commits intodevelfrom
jpuerto-psc merged 16 commits intodevelfrom
Conversation
gesinaphillips
force-pushed
the
phillips/notify_updates
branch
from
b249dde to
29aa6d0
Compare
gesinaphillips
commented
Apr 28, 2026
gesinaphillips
commented
Apr 28, 2026
| return self.status_str.title() | ||
|
|
||
| @staticmethod | ||
| def valid_str(status: Union[str, Statuses]) -> str: |
Collaborator
Author
There was a problem hiding this comment.
Consolidated this logic into get_status_enum
gesinaphillips
commented
Apr 28, 2026
| return response.json() | ||
|
|
||
|
|
||
| def get_globus_url(entity_data: dict, token: str) -> str: |
Collaborator
Author
There was a problem hiding this comment.
New get_globus_url func
gesinaphillips
commented
Apr 28, 2026
gesinaphillips
commented
Apr 28, 2026
| ).update() | ||
|
|
||
| @staticmethod | ||
| def _enums_to_lowercase(data: Any) -> Any: |
Collaborator
Author
There was a problem hiding this comment.
Moved to utils.py
gesinaphillips
commented
Apr 28, 2026
|
|
||
|
|
||
| def get_status_enum(entity_type: str, status: Statuses | str, uuid: str) -> Statuses: | ||
| def get_status_enum(entity_type: str, status: Statuses | str) -> Statuses: |
Collaborator
Author
There was a problem hiding this comment.
Updated func, incorporates validation logic from Statuses.valid_str
gesinaphillips
commented
Apr 28, 2026
| SENNET = ("sennet", "SenNet") | ||
|
|
||
|
|
||
| globus_dirs = { |
Collaborator
Author
There was a problem hiding this comment.
Deprecated by new status_utils.get_globus_url
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major changes
erroremail language for when pipeline fails before derived dataset is created; added pipeline nameget_globus_url:Bugfixes/updates
run_idfirstreindexparam to default toreindex-priority=3but also allow settingreindex=<1, 2>orreindex=True(transformed intoreindex-priority=1*)* Is this the right call?
Refactoring
EntityUpdater._enums_to_lowercase->utils.enums_to_lowercasestatus_utils.get_env->utils.get_envutils.format_multilineto help with formatting long messagesstatus_utils.pyStatuses.valid_strintoget_status_enum