Conversation
sunset666
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pending hopeful conclusion of Matt's testing in the case where the OME-TIFF was taking precedence in the pipeline. Will update if that does not show the expected outcome.Update: I used the same process as in the phenocycler pipeline to convert the QPTIFF in
7154fcff524c3e21110cd4b47310a66bto an OME-TIFF and the results validated my approach here. The OME-TIFF used by the pipeline should have the same channels as I am retrieving from the QPTIFF in this plugin.Added verification that the channels in
qptiff.channels.csvmatch channels in QPTIFF file. Required some rearranging of existing QPTIFF validator. No tests integrated (yet) due to difficulty creating a small enough QPTIFF fixture or mocking data meaningfully.May need to add comparable OME-TIFF test, but currently seems unnecessary since OME-TIFFs are not allowed in the phenocycler directory schema outside of the
extrasdirectory.