NickAkhmetov/CAT-1502 Replace organs with publications in homepage entity counts#3925
Open
NickAkhmetov wants to merge 2 commits intonickakhmetov/cat-1501-homepagefrom
Open
NickAkhmetov/CAT-1502 Replace organs with publications in homepage entity counts#3925NickAkhmetov wants to merge 2 commits intonickakhmetov/cat-1501-homepagefrom
NickAkhmetov wants to merge 2 commits intonickakhmetov/cat-1501-homepagefrom
Conversation
…508-entity-counts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the organ counts from the homepage and replaces them with the collection and publication counts. I also used this opportunity to unify the handling for all entity counts' props, since they are now all fetched from the Search API.
Design Documentation/Original Tickets
https://hms-dbmi.atlassian.net/browse/CAT-1502
Testing/Screenshots/Video
Desktop:
Mobile:
Checklist
CHANGELOG-your-feature-name-here.mdis present in the root directory, describing the change(s) in full sentences.