NickAkhmetov/CAT-1490 Add ATAC modality support to scFind queries#3961
Open
NickAkhmetov wants to merge 11 commits intomainfrom
Open
NickAkhmetov/CAT-1490 Add ATAC modality support to scFind queries#3961NickAkhmetov wants to merge 11 commits intomainfrom
NickAkhmetov wants to merge 11 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for querying ATAC experiments using the scfind API.
While implementing this, I also improved error handling for scFind requests throughout the site and adjusted gene pathway validation to be done server-side to cut down on back-and-forth. The old flow had the client requesting the pathway genes directly from the ubkg API, then sending them to the flask back-end for validation; the new flow sends the request for pathway genes to our back-end, which also evaluates which genes are available for the selected modality.
Design Documentation/Original Tickets
https://hms-dbmi.atlassian.net/browse/CAT-1490
Testing
Added unit/integration tests
Screenshots/Video
Note that PMAIP and BBC3 are not present in the RNAseq index; pathway gene validation handling has been updated to account for the current selected modality.
Checklist
CHANGELOG-your-feature-name-here.mdis present in the root directory, describing the change(s) in full sentences.Additional Notes
Please specify any additional information or context relevant to this PR.