Derek furst/optimize generate doc#1025
Merged
yuanzhou merged 3 commits intodev-integratefrom Apr 23, 2026
Merged
Conversation
… of passing ids rather than whole entities
…orm of arguments passed by the legacy translate pipipeline. adjusted some logs to go along with that
…c' into Derek-Furst/optimize-generate-doc
yuanzhou
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix addresses an incompatibility between the translate_all workflow and the reworked individual reindex workflow. Translate_uploads|collections used to take an id, then superfluously call entity to get the whole dict. Now we just accept the whole dict, but this broke the calls made from the translate-all workflow. in order to preserve the legacy code, I modified the translate_upload and translate_collection to accept either the id itself, or the whole entity. Changed some logs that referenced the entity id to go along with that