Open
Conversation
novawish
reviewed
Aug 31, 2019
| newdict = {} | ||
| if not match: | ||
| print 'no match', repr(line) | ||
| ('no match', repr(line)) |
Author
There was a problem hiding this comment.
Well spotted, I think that one was deleted in eror.
novawish
reviewed
Sep 22, 2019
|
|
||
|
|
||
| import binpack_simple | ||
| import pyshipping.binpack_simple |
There was a problem hiding this comment.
I have this error when calling the funtion binpack below this line
NameError: name 'binpack_simple' is not defined
In my opinion, we should do something like this:
import pyshipping.binpack_simple as binpack_simple
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.