fix pathlib.Path support in save_to_disk and load_from_disk#8202
Open
JiwaniZakir wants to merge 2 commits into
Open
fix pathlib.Path support in save_to_disk and load_from_disk#8202JiwaniZakir wants to merge 2 commits into
JiwaniZakir wants to merge 2 commits into
Conversation
`url_to_fs` from fsspec does not accept `pathlib.Path` objects, only strings. Convert `dataset_path` to `str` before passing to `url_to_fs` in `Dataset.save_to_disk`, `Dataset.load_from_disk`, `DatasetDict.save_to_disk`, `DatasetDict.load_from_disk`, and the top-level `load_from_disk`. Fixes huggingface#6829
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
url_to_fsfrom fsspec only accepts strings, butsave_to_diskandload_from_diskinarrow_dataset.py,dataset_dict.py, andload.pypass the user-supplied path directly without converting it, causing a crash when apathlib.Pathis provided. Addedstr()conversion at eachurl_to_fscall site so all path-like objects are handled correctly. To verify, calldataset.save_to_disk(Path("my_dir"))andDataset.load_from_disk(Path("my_dir"))with apathlib.Path.Fixes #6829