Support composed splits in streaming datasets#8220
Open
lanarkite99 wants to merge 1 commit into
Open
Conversation
Author
|
@lhoestq could you please review this PR when you get a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2699
Fixes #4804
This PR adds support for unsliced split composition when loading datasets in streaming mode, e.g.
split="train+validation".Previously,
DatasetBuilder.as_streaming_dataset()only accepted a single split name or returned all splits as anIterableDatasetDict, so composed split strings raisedValueError: Bad split.The change resolves composed split instructions by building each requested streaming split and concatenating the resulting
IterableDatasets. It also supports theallsplit sentinel in streaming mode.This intentionally does not add support for sliced streaming expressions such as
train[:10%], which require separate handling.Tests added for:
"train+test"Split.TRAIN + Split.TEST"all"Split.ALLValidation:
python -m pytest tests/test_builder.py -q