Skip to content

Security/Logic Fix: Autonomous Code Review #8227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fliptrigga13 wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −15
Open

Security/Logic Fix: Autonomous Code Review #8227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 18 additions & 15 deletions src/datasets/io/generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,25 +15,23 @@ def __init__(
streaming: bool = False,
gen_kwargs: Optional[dict] = None,
num_proc: Optional[int] = None,
split: NamedSplit = Split.TRAIN,
split: NamedSplit,
fingerprint: Optional[str] = None,
**kwargs,
):
super().__init__(
features=features,
cache_dir=cache_dir,
keep_in_memory=keep_in_memory,
streaming=streaming,
num_proc=num_proc,
**kwargs,
)
self.builder = Generator(
cache_dir=cache_dir,
features=features,
generator=generator,
gen_kwargs=gen_kwargs,
split=split,
config_id="default-fingerprint=" + fingerprint if fingerprint else None,
config_id=f"default-fingerprint={fingerprint}" if fingerprint else None,
**kwargs,
)
self.fingerprint = fingerprint
Expand All @@ -49,14 +47,19 @@ def read(self):
verification_mode = None
base_path = None

self.builder.download_and_prepare(
download_config=download_config,
download_mode=download_mode,
verification_mode=verification_mode,
base_path=base_path,
num_proc=self.num_proc,
)
dataset = self.builder.as_dataset(split=self.builder.config.split, in_memory=self.keep_in_memory)
if self.fingerprint:
dataset._fingerprint = self.fingerprint
return dataset
try:
self.builder.download_and_prepare(
download_config=download_config,
download_mode=download_mode,
verification_mode=verification_mode,
base_path=base_path,
num_proc=self.num_proc,
)
dataset = self.builder.as_dataset(split=self.builder.config.split, in_memory=self.keep_in_memory)
if self.fingerprint:
dataset._fingerprint = self.fingerprint
except Exception as e:
print(f"An error occurred while reading the dataset: {e}")
raise

return dataset