Add jobs in @huggingface/hub & hfjs cli#1925
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- Add null check for envVars before iterating (matching secretVars pattern) - Add existence check for providedPositionalTokens[i] before accessing .value Co-authored-by: eliott <eliott@huggingface.co>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
- Fix ParsedArgsResult type: multiple optional options can be undefined - Use hf.co/ prefix to identify Space IDs, otherwise treat as Docker image This fixes the issue where org/image Docker images without tags were misidentified as HuggingFace Space IDs Co-authored-by: eliott <eliott@huggingface.co>
| if (firstArg.startsWith("hf.co/")) { | ||
| // hf.co/spaces/namespace/space-name or hf.co/namespace/space-name | ||
| const hfCoSpacesMatch = firstArg.match(/^hf\.co\/spaces\/(.+)$/); | ||
| if (hfCoSpacesMatch) { | ||
| spaceId = hfCoSpacesMatch[1]; | ||
| } else { | ||
| // hf.co/namespace/space-name format | ||
| spaceId = firstArg.slice("hf.co/".length); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
@cursor just check on hf.co/spaces/* and extract the space id ("*") do not handle any other format for space id
There was a problem hiding this comment.
Simplified the Space ID detection logic:
- Only
hf.co/spaces/*format is recognized as a Space ID (extracts the*part) - Everything else is treated as a Docker image
This removes the ambiguity with Docker images like pytorch/pytorch or nvidia/cuda.
Everything else is treated as a Docker image. Co-authored-by: eliott <eliott@huggingface.co>
3 participants
cf @Wauplin for viz
useful to test jobs change in hf.co (ongoing PRs)
cli only contains a few endpoints, and tries to use same syntax as python lib
diffrence with python cli:
(was complicated to do otherwise)
Note
Adds first-class Jobs support to the JS Hub SDK and CLI.
runJob,listJobs,getJob,duplicateJob,cancelJob, log/event/metric streaming, hardware listing, and full scheduled jobs lifecycle (create,list,get,run,suspend,resume,delete); exported viasrc/lib/jobsand new API types.hfjs): newjobssubcommands—run,ps,hardware,logs—with env/secret flags, hardware flavor selection, log streaming, and namespace auto-resolve; improved--helphandling and advanced arg parsing (multi-value positionals/options).SpaceHardwareFlavorset and introduce job types (ApiJob,ApiScheduledJob, etc.).hfjs help jobs; tsconfig enables source maps.Written by Cursor Bugbot for commit b1e9e87. This will update automatically on new commits. Configure here.