Set kernels optional dependency via transformers#5884
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
kernelsoptional dependency viatransformers[kernels].This PR updates the way the
kernelsdependency is specified in both the main and development dependencies inpyproject.toml. Instead of directly depending on thekernelspackage, the project now relies on thetransformers[kernels]extra, which should simplify dependency management and improve compatibility.Related to:
Motivation
Since TRL does not directly depend on the kernels package itself, the new extra simply re-exports the corresponding transformers extra instead of duplicating its dependency specification. This keeps transformers as the single source of truth for the underlying package requirements and version constraints.
This also ensures we automatically inherit both the lower and upper version bounds defined upstream (and any future updates to them), avoiding duplication in TRL.
Changes
Dependency management updates:
kernels<0.15.1withtransformers[kernels]in the main dependencies list.transformers[kernels]instead ofkernels<0.15.1.Note
Low Risk
Packaging-only change with no runtime code; install graphs may shift if Transformers' kernels extra differs from the old pin.
Overview
The
kernelsoptional extra and thedevdependency bundle no longer pinkernels<0.15.1directly. Both now installtransformers[kernels], so kernel package versions and bounds come from Transformers instead of being duplicated in TRL (related to GH-5878 / #5880).Reviewed by Cursor Bugbot for commit bf88f15. Bugbot is set up for automated code reviews on this repo. Configure here.