Skip to content

fix: keep an empty-string key on unflatten instead of renaming it to 0 #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spokodev wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −0
Open

fix: keep an empty-string key on unflatten instead of renaming it to 0 #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ export function unflatten (target, opts) {
// safely ensure that the key is
// an integer.
function getkey (key) {
// `Number('')` is 0 (not NaN), so an empty-string key would be coerced to
// the numeric index 0 and renamed; keep it as-is.
if (key === '') return key

const parsedKey = Number(key)

return (
Expand Down
6 changes: 6 additions & 0 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,6 +566,12 @@ describe('Arrays', function () {
}))
})

test('Should keep an empty-string key instead of renaming it to 0', function () {
assert.deepStrictEqual({ '': 1, x: 2 }, unflatten({ '': 1, x: 2 }))
assert.deepStrictEqual({ a: { '': 1 } }, unflatten({ 'a.': 1 }))
assert.deepStrictEqual({ '': 1, x: 2 }, unflatten(flatten({ '': 1, x: 2 })))
})

test('Array typed objects should be restored by unflatten', function () {
assert.strictEqual(
Object.prototype.toString.call(['foo', 'bar'])
Expand Down