Skip to content

toml v4#256

Merged
hugoh merged 4 commits into
mainfrom
toml-v4
Jun 3, 2026
Merged

toml v4#256
hugoh merged 4 commits into
mainfrom
toml-v4

Conversation

@hugoh

@hugoh hugoh commented Jun 3, 2026

Copy link
Copy Markdown
Owner
  • fix(conf): validation check
  • feat: moved to TOML
  • refactor(logic): move statServerConfig from Configure to Run
  • fix(logic): nil statServer on Stop to allow restart on SIGHUP

@sonarqubecloud

sonarqubecloud Bot commented Jun 3, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.16%. Comparing base (1055b25) to head (fdc8d5e).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/conf.go 85.71% 2 Missing and 1 partial ⚠️
internal/logic/loop.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
+ Coverage   85.99%   88.16%   +2.17%     
==========================================
  Files          19       19              
  Lines         878      845      -33     
==========================================
- Hits          755      745      -10     
+ Misses         91       69      -22     
+ Partials       32       31       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@deepsource-io

deepsource-io Bot commented Jun 3, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 1055b25...fdc8d5e on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Go Jun 3, 2026 1:13p.m. Review ↗
Secrets Jun 3, 2026 1:13p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@hugoh hugoh merged commit a3c86f8 into main Jun 3, 2026
9 checks passed
@hugoh hugoh deleted the toml-v4 branch June 3, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant