Skip to content

fix/loops#259

Merged
hugoh merged 12 commits into
mainfrom
fix/loops
Jun 8, 2026
Merged

fix/loops#259
hugoh merged 12 commits into
mainfrom
fix/loops

Conversation

@hugoh

@hugoh hugoh commented Jun 8, 2026

Copy link
Copy Markdown
Owner
  • fix: increased logging for failed checks & down action
  • refactor(downaction): simplified loop
  • refactor(loop): remove no-op timer.Stop and inline hasDownAction
  • refactor(downaction): remove no-op timer.Stop and dead ErrInvalidCommand
  • refactor(cmd): remove dead ExitCodeError and ConfigDump
  • refactor(status): remove unused NewStatHandler constructor
  • refactor(conf): simplify redundant var declaration
  • refactor(status): inline InvalidRangeMsg const
  • refactor(status): inline InvalidRangeMsg const
  • refactor(check): remove unused Report getter methods
  • refactor: fixed linting issues
  • fix(dns): probe config parsing

@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 67.34694% with 64 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.91%. Comparing base (ad309d6) to head (1ff7c1d).

Files with missing lines Patch % Lines
internal/logic/downaction.go 67.90% 25 Missing and 1 partial ⚠️
internal/status/stat-server.go 32.25% 21 Missing ⚠️
internal/conf.go 78.94% 8 Missing ⚠️
internal/cmd.go 16.66% 5 Missing ⚠️
internal/logic/loop.go 85.18% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
- Coverage   88.36%   83.91%   -4.45%     
==========================================
  Files          18       18              
  Lines         842      920      +78     
==========================================
+ Hits          744      772      +28     
- Misses         67      116      +49     
- Partials       31       32       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud

sonarqubecloud Bot commented Jun 8, 2026

Copy link
Copy Markdown

@deepsource-io

deepsource-io Bot commented Jun 8, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in ad309d6...1ff7c1d on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Go Jun 8, 2026 3:46a.m. Review ↗
Secrets Jun 8, 2026 3:46a.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@hugoh hugoh merged commit 56ed78a into main Jun 8, 2026
7 of 9 checks passed
@hugoh hugoh deleted the fix/loops branch June 8, 2026 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant